Stream: git-wasmtime

Topic: wasmtime / PR #5307 Reduce SigData size further


view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2022 at 07:06):

tnachen opened PR #5307 from tnachen/sigset to main:

Changed stack_ret_arg to become a boolean on SigData, as the stack_return_arg is always the last argument.
Refactored all SigSet methods on SigData to be in SigSet instead.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2022 at 16:23):

tnachen updated PR #5307 from tnachen/sigset to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2022 at 17:05):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2022 at 17:05):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2022 at 17:05):

jameysharp created PR review comment:

A small note: Sig doesn't need to be passed by reference in any of these functions. It's only a 32-bit value. SigData was passed by reference because, as you're working on fixing, it was much larger.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 00:02):

tnachen updated PR #5307 from tnachen/sigset to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 00:03):

abrown updated PR #5307 from tnachen/sigset to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 00:16):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 00:16):

jameysharp created PR review comment:

This is a small thing, but could you put this back the way it was before?

        if let Some(i) = sigs[self.sig].stack_ret_arg {

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 00:16):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 00:16):

jameysharp created PR review comment:

I wouldn't bother to mention this except I'm making some other requests already: could you put this blank line back?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 00:16):

jameysharp created PR review comment:

I would like you to remove the & from all the &Sig parameters, which will mean removing some * dereferences in a few places too. I hope that's easy to do, but let me know if it turns out to be complicated for some reason I haven't thought of.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 03:01):

tnachen updated PR #5307 from tnachen/sigset to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 03:03):

tnachen updated PR #5307 from tnachen/sigset to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 04:01):

tnachen updated PR #5307 from tnachen/sigset to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2022 at 07:18):

tnachen requested jameysharp for a review on PR #5307.


Last updated: Dec 23 2024 at 12:05 UTC