Stream: git-wasmtime

Topic: wasmtime / PR #5303 Move the endianness notes introduced ...

Wasmtime GitHub notifications bot (Nov 19 2022 at 20:33):

kpreisser opened PR #5303 from fix-c-api-endianness-notes to main:

Hi, it seems #4035 mistakenly added the notes about the little-endian storage to to wasmtime_valunion, whereas it's actually the ValRaw Rust type (represented by wasmtime_val_raw) that is affected by the change.

Thanks!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 20 2022 at 19:44):

kpreisser edited PR #5303 from fix-c-api-endianness-notes to main:

Hi, it seems #4035 mistakenly added the notes about the little-endian storage in the C API to wasmtime_valunion, whereas it's actually the ValRaw Rust type (represented by wasmtime_val_raw) that is affected by the change.

Thanks!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 21 2022 at 16:37):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 21 2022 at 16:37):

alexcrichton merged PR #5303.

Last updated: Nov 22 2024 at 17:03 UTC