Stream: git-wasmtime

Topic: wasmtime / PR #5301 Fix implicit pointer argument registe...

Wasmtime GitHub notifications bot (Nov 18 2022 at 22:12):

elliottt opened PR #5301 from trevor/constrain-implicit-ptr-registers to main:

Constrain virtual registers when handling implicit pointer arguments, instead of using physical registers directly.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 18 2022 at 23:02):

elliottt has marked PR #5301 as ready for review.

Wasmtime GitHub notifications bot (Nov 18 2022 at 23:46):

elliottt updated PR #5301 from trevor/constrain-implicit-ptr-registers to main.

Wasmtime GitHub notifications bot (Nov 18 2022 at 23:48):

elliottt edited PR #5301 from trevor/constrain-implicit-ptr-registers to main:

Constrain virtual registers when handling implicit pointer arguments, instead of using physical registers directly. Additionally, mark the Args instruction as not clobbering registers in the s390x and aarch64 backends, to avoid introducing unnecessary saves on function entry.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Last updated: Oct 23 2024 at 20:03 UTC