Stream: git-wasmtime

Topic: wasmtime / PR #5299 Deduplicate listings of traps in Wasm...

Wasmtime GitHub notifications bot (Nov 18 2022 at 20:03):

alexcrichton opened PR #5299 from less-trap to main:

This commit replaces wasmtime_environ::TrapCode with wasmtime::Trap. This is possible with past refactorings which slimmed down the Trap definition in the wasmtime crate to a simple enum. This means that there's one less place that all the various trap opcodes need to be listed in Wasmtime.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 18 2022 at 20:29):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 18 2022 at 20:31):

alexcrichton has enabled auto merge for PR #5299.

Wasmtime GitHub notifications bot (Nov 18 2022 at 21:18):

alexcrichton updated PR #5299 from less-trap to main.

Wasmtime GitHub notifications bot (Nov 18 2022 at 22:04):

alexcrichton merged PR #5299.

Last updated: Nov 22 2024 at 17:03 UTC