Stream: git-wasmtime

Topic: wasmtime / PR #5294 cranelift-isle: Unify expressions and...

Wasmtime GitHub notifications bot (Nov 17 2022 at 23:14):

jameysharp opened PR #5294 from isle-unify-bindings to main:

As it turns out, that distinction was not necessary for this representation. Removing it eliminates some complexity around wrapping expressions as bindings and vice versa. It also clears up some confusion about which category to put certain constructs in (arguments and extractors) by refusing to have different categories.

While I was writing this patch I also realized that add_match_variant and normalize_equivalence_classes both need to do fundamentally the same things with enum variants, so I refactored them to share code and make their relationship clearer.

Finally, I reviewed all the comments in this file and fixed some places where they could be more clear.

Wasmtime GitHub notifications bot (Nov 17 2022 at 23:14):

jameysharp requested cfallin for a review on PR #5294.

Wasmtime GitHub notifications bot (Nov 17 2022 at 23:59):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 18 2022 at 00:01):

jameysharp merged PR #5294.

Last updated: Nov 22 2024 at 16:03 UTC