Stream: git-wasmtime

Topic: wasmtime / PR #5286 Skip running release builds on PRs

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:00):

elliottt opened PR #5286 from trevor/skip-release-builds-on-branches to main:

Disable the Build jobs on branches, but leave it for main and version tag builds.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:03):

elliottt edited PR #5286 from trevor/skip-release-builds-on-branches to main:

Disable the Build jobs on branches, but leave it for main and version tag builds. We'll need to remove the Build jobs as requirements for merging for this PR to be mergable.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:08):

elliottt edited PR #5286 from trevor/skip-release-builds-on-branches to main:

Disable the Build jobs on branches, but leave it for main and version tag builds. We'll need to remove the Build jobs as requirements for merging for this PR to be mergable. This won't substantially reduce build time, but it will reduce the number of parallel jobs spawned, which should free up some capacity organization-wide.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:09):

elliottt has marked PR #5286 as ready for review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:09):

elliottt requested alexcrichton for a review on PR #5286.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:10):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:10):

elliottt created PR review comment:

I'm undecided about leaving this guard in. It seems nice to avoid accidentally triggering this in the future, but it's also redundant with the new if at the job level.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:18):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:35):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:37):

jameysharp created PR review comment:

How about using this pattern?

        startsWith(github.ref, 'refs/heads/release-')

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:37):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:38):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:38):

elliottt created PR review comment:

That works for me!

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:39):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:40):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:40):

elliottt created PR review comment:

I'll add a note about keeping it because we run these jobs on release-* branches.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:40):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:49):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:49):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:49):

alexcrichton created PR review comment:

I think that this may not actually fire for release-* branches since we already only run for push events on the main branch only (plus tags). Could this be inverted as "run if not PR or if release branch?"

Wasmtime GitHub notifications bot (Nov 17 2022 at 01:10):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 01:12):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 01:12):

elliottt created PR review comment:

I had totally forgotten about the top-level on predicate, thanks for catching this!

Wasmtime GitHub notifications bot (Nov 17 2022 at 02:29):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 02:29):

alexcrichton created PR review comment:

Could this have a pull_request: added the release-* branches as well? Additionally it should be ok to remove release-* from the branches: to avoid the double builds for PRs and release branches on merge.

Wasmtime GitHub notifications bot (Nov 17 2022 at 04:49):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 04:53):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 04:54):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 15:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 17 2022 at 17:31):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 17:36):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 17:36):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 17:37):

elliottt updated PR #5286 from trevor/skip-release-builds-on-branches to main.

Wasmtime GitHub notifications bot (Nov 17 2022 at 18:23):

elliottt edited PR #5286 from trevor/skip-release-builds-on-branches to main:

Disable the Build jobs on branches, but leave it for main, version tag, and release-* builds. We'll need to remove the Build jobs as requirements for merging for this PR to be mergable. This won't substantially reduce build time, but it will reduce the number of parallel jobs spawned, which should free up some capacity organization-wide.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 17 2022 at 18:24):

elliottt merged PR #5286.

Last updated: Nov 22 2024 at 16:03 UTC