Stream: git-wasmtime

Topic: wasmtime / PR #5285 Cranelift: Implement `iadd_cout` on x...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2022 at 23:27):

fitzgen opened PR #5285 from impl-iadd-cout to main:

Builds on top of https://github.com/bytecodealliance/wasmtime/pull/5177

view this post on Zulip Wasmtime GitHub notifications bot (Nov 16 2022 at 23:27):

fitzgen requested elliottt for a review on PR #5285.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2022 at 00:36):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2022 at 00:36):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2022 at 00:36):

elliottt created PR review comment:

Should these to be disabled for x86_64? They're both implemented in lower.isle now.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2022 at 00:39):

jameysharp created PR review comment:

Yeah, I guess that's an artifact of basing this PR on top of #5177.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 17 2022 at 00:39):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2022 at 20:41):

fitzgen updated PR #5285 from impl-iadd-cout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2022 at 20:41):

fitzgen requested elliottt for a review on PR #5285.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2022 at 23:42):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2022 at 23:42):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2022 at 23:42):

elliottt created PR review comment:

What about restricting the carry operations to i64/i32?

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2022 at 19:21):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2022 at 19:21):

fitzgen created PR review comment:

We could do that, but that is a CLIF semantics decision rather than an implementation decision (this comment is regarding the latter).

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2022 at 19:22):

fitzgen has enabled auto merge for PR #5285.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2022 at 19:22):

fitzgen has disabled auto merge for PR #5285.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2022 at 19:23):

fitzgen updated PR #5285 from impl-iadd-cout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2022 at 19:23):

fitzgen has enabled auto merge for PR #5285.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 07 2022 at 19:54):

fitzgen merged PR #5285.

Last updated: Dec 23 2024 at 12:05 UTC