Stream: git-wasmtime

Topic: wasmtime / PR #5284 Docs: Expand cross compiling section ...

Wasmtime GitHub notifications bot (Nov 16 2022 at 20:44):

fitzgen opened PR #5284 from cross-compilation-docs to main:

And fill out everything needed for all non-x64 targets supported by Wasmtime and Cranelift.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 16 2022 at 20:44):

fitzgen requested alexcrichton for a review on PR #5284.

Wasmtime GitHub notifications bot (Nov 16 2022 at 21:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 16 2022 at 21:01):

cfallin created PR review comment:

The old version had an example of a commandline invocation of wasmtime as well; this can be useful in certain cases (e.g. testing with a particular wasm file). Could we keep the note about that, or at least note above that the runner commandlines can be used to run the cross-architecture binary directly if desired? (Also on that note, I notice the cargo build ... example is gone -- it's useful to indicate that one can do that as well, and the path where the cross-architecture binary ends up)

Wasmtime GitHub notifications bot (Nov 16 2022 at 21:01):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 16 2022 at 23:17):

fitzgen updated PR #5284 from cross-compilation-docs to main.

Wasmtime GitHub notifications bot (Nov 16 2022 at 23:18):

fitzgen has enabled auto merge for PR #5284.

Wasmtime GitHub notifications bot (Nov 16 2022 at 23:32):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 16 2022 at 23:49):

fitzgen merged PR #5284.

Last updated: Oct 23 2024 at 20:03 UTC