Stream: git-wasmtime

Topic: wasmtime / PR #5278 Don't use %rcx directly with CoffTlsG...

Wasmtime GitHub notifications bot (Nov 16 2022 at 00:53):

elliottt opened PR #5278 from trevor/coff-tls-addr-rcx-fix to main:

Avoid naming %rcx as written by the CoffTlsGetAddr pseudo-instruction in the x64 backend, and isntead emit a fixed-def constraint for a fresh VReg and %rcx.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 16 2022 at 01:56):

elliottt updated PR #5278 from trevor/coff-tls-addr-rcx-fix to main.

Wasmtime GitHub notifications bot (Nov 16 2022 at 05:22):

elliottt has marked PR #5278 as ready for review.

Wasmtime GitHub notifications bot (Nov 16 2022 at 18:52):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 16 2022 at 19:32):

elliottt edited PR #5278 from trevor/coff-tls-addr-rcx-fix to main:

Avoid naming %rcx as written by the CoffTlsGetAddr pseudo-instruction in the x64 backend, and instead emit a fixed-def constraint for a fresh VReg and %rcx.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 16 2022 at 19:32):

elliottt merged PR #5278.

Last updated: Nov 22 2024 at 17:03 UTC