elliottt opened PR #5277 from trevor/remove-unnecessary-memcpy-moves
to main
:
Remove some unnecessary moves in the x64
gen_memcpy
implementation -- the call instruction that's generated will already constrain the args to those registers.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
elliottt has marked PR #5277 as ready for review.
elliottt submitted PR review.
elliottt created PR review comment:
Was this mov a bug in the previous lowering?
%r14
at that point would bev2
so moving it in at this point would usev2
for thev1
memcpy.
elliottt deleted PR review comment.
cfallin submitted PR review.
elliottt created PR review comment:
This is one of the moves removed by this PR, and is redundant with the move on line 139.
elliottt submitted PR review.
elliottt merged PR #5277.
Last updated: Dec 23 2024 at 13:07 UTC