Wasmtime GitHub notifications bot (Nov 16 2022 at 00:51): Wasmtime GitHub notifications bot (Nov 16 2022 at 00:51):elliottt opened PR #5277 from trevor/remove-unnecessary-memcpy-moves to main:
Remove some unnecessary moves in the x64
gen_memcpyimplementation -- the call instruction that's generated will already constrain the args to those registers.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 16 2022 at 05:22):elliottt has marked PR #5277 as ready for review.
Wasmtime GitHub notifications bot (Nov 16 2022 at 18:30):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Nov 16 2022 at 18:30):elliottt created PR review comment:
Was this mov a bug in the previous lowering?
%r14at that point would bev2so moving it in at this point would usev2for thev1memcpy.
Wasmtime GitHub notifications bot (Nov 16 2022 at 18:30):elliottt deleted PR review comment.
Wasmtime GitHub notifications bot (Nov 16 2022 at 18:32):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Nov 16 2022 at 18:32):elliottt created PR review comment:
This is one of the moves removed by this PR, and is redundant with the move on line 139.
Wasmtime GitHub notifications bot (Nov 16 2022 at 18:32):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Nov 16 2022 at 18:33):elliottt merged PR #5277.
Last updated: Nov 22 2024 at 17:03 UTC