Stream: git-wasmtime

Topic: wasmtime / PR #5272 Cranelift: Do not optimize heap bound...

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:41):

fitzgen requested elliottt for a review on PR #5272.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:41):

fitzgen opened PR #5272 from no-optimize-bounds-checks-in-legalization to main:

That optimization is only for 12-bit immediates in Aarch64, which is now handled in backend lowering, so we can simplify this code a bit now.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:44):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:49):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 18:02):

fitzgen has enabled auto merge for PR #5272.

Wasmtime GitHub notifications bot (Nov 15 2022 at 19:54):

fitzgen merged PR #5272.

Last updated: Dec 23 2024 at 12:05 UTC