Stream: git-wasmtime

Topic: wasmtime / PR #5261 Shrink the size of SigData in Cranelift

Wasmtime GitHub notifications bot (Nov 14 2022 at 05:22):

tnachen opened PR #5261 from tnachen/sigdata_size to main:

Addressing #5183 based on discussion on making SigData struct smaller

Wasmtime GitHub notifications bot (Nov 14 2022 at 17:13):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 14 2022 at 17:13):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 14 2022 at 17:13):

jameysharp created PR review comment:

I'd prefer if this was u32::from(self.args_length) instead of using the as operator, and similarly in rets below. That documents that we expect the conversion to always successfully preserve value, and does so in a way that the compiler will check for us.

Wasmtime GitHub notifications bot (Nov 14 2022 at 17:13):

jameysharp created PR review comment:

usize::try_from was necessary when len was a u32, because I guess Rust supports targets with 16-bit usize. But both here and in num_rets below, you can just use usize::from since these lengths are u16 now.

Wasmtime GitHub notifications bot (Nov 15 2022 at 06:19):

tnachen updated PR #5261 from tnachen/sigdata_size to main.

Wasmtime GitHub notifications bot (Nov 15 2022 at 16:34):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 16:34):

jameysharp created PR review comment:

Unless I've missed something, you can use usize::from here as well, right?

        usize::from(self.rets_length)

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:02):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 18:21):

tnachen updated PR #5261 from tnachen/sigdata_size to main.

Wasmtime GitHub notifications bot (Nov 16 2022 at 07:12):

tnachen updated PR #5261 from tnachen/sigdata_size to main.

Wasmtime GitHub notifications bot (Nov 16 2022 at 22:36):

tnachen updated PR #5261 from tnachen/sigdata_size to main.

Wasmtime GitHub notifications bot (Nov 16 2022 at 22:43):

tnachen updated PR #5261 from tnachen/sigdata_size to main.

Wasmtime GitHub notifications bot (Nov 16 2022 at 23:24):

tnachen updated PR #5261 from tnachen/sigdata_size to main.

Wasmtime GitHub notifications bot (Nov 16 2022 at 23:31):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 16 2022 at 23:32):

jameysharp has enabled auto merge for PR #5261.

Wasmtime GitHub notifications bot (Nov 17 2022 at 00:15):

jameysharp merged PR #5261.

Last updated: Dec 23 2024 at 12:05 UTC