Stream: git-wasmtime

Topic: wasmtime / PR #5253 Add fixed_nonallocatable constraints ...

Wasmtime GitHub notifications bot (Nov 11 2022 at 02:16):

elliottt opened PR #5253 from trevor/add-fixed-nonallocatable-operands to main:

Add fixed-nonallocatable constraints when argument registers are physical but come from the nonallocatable set.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 11 2022 at 02:20):

elliottt edited PR #5253 from trevor/add-fixed-nonallocatable-operands to main:

Plumb the set of allocatable registers through the OperandCollector and use it to determine when operands come from the fixed-nonallocatable set. Augment the existing constraint generation functions to detect this case, and generate fixed_nonallocatable constraints when appropriate.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 11 2022 at 04:32):

elliottt updated PR #5253 from trevor/add-fixed-nonallocatable-operands to main.

Wasmtime GitHub notifications bot (Nov 11 2022 at 05:49):

elliottt has marked PR #5253 as ready for review.

Wasmtime GitHub notifications bot (Nov 14 2022 at 22:18):

elliottt updated PR #5253 from trevor/add-fixed-nonallocatable-operands to main.

Wasmtime GitHub notifications bot (Nov 14 2022 at 22:19):

elliottt requested fitzgen for a review on PR #5253.

Wasmtime GitHub notifications bot (Nov 14 2022 at 23:46):

elliottt updated PR #5253 from trevor/add-fixed-nonallocatable-operands to main.

Wasmtime GitHub notifications bot (Nov 15 2022 at 16:46):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 16:46):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 16:46):

fitzgen created PR review comment:

Did you try reusing 'func here by chance and find that a new lifetime was actually necessary to get the code to compile? This is pretty invasive and adds a third(!!) lifetime to the IsleContext so if it isn't actually necessary it would be nice to skip.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:00):

elliottt created PR review comment:

I didn't try that, as I was assuming that the two structures would come from different lifetimes. I'll give that a try, and see if anything breaks.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:00):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:00):

elliottt edited PR review comment.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:02):

elliottt updated PR #5253 from trevor/add-fixed-nonallocatable-operands to main.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:15):

elliottt updated PR #5253 from trevor/add-fixed-nonallocatable-operands to main.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:15):

elliottt created PR review comment:

That worked, thanks for pointing this out!

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:15):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:26):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:26):

elliottt created PR review comment:

Now that I'm thinking about this, we don't need the actual MachineEnv plumbed through, just the PRegSet that's used in the OperandCollector. Moving the creation of the PRegSet to Lower::new removes the MachineEnv reference, and only iterates it once instead of for each instruction.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:42):

elliottt updated PR #5253 from trevor/add-fixed-nonallocatable-operands to main.

Wasmtime GitHub notifications bot (Nov 15 2022 at 17:45):

elliottt updated PR #5253 from trevor/add-fixed-nonallocatable-operands to main.

Wasmtime GitHub notifications bot (Nov 15 2022 at 19:07):

elliottt has marked PR #5253 as ready for review.

Wasmtime GitHub notifications bot (Nov 15 2022 at 20:48):

elliottt edited PR #5253 from trevor/add-fixed-nonallocatable-operands to main:

Plumb the set of allocatable registers through the OperandCollector and use it validate uses of fixed-nonallocatable registers, like %rsp on x86_64.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 15 2022 at 20:49):

elliottt merged PR #5253.

Last updated: Dec 23 2024 at 12:05 UTC