Stream: git-wasmtime

Topic: wasmtime / PR #5251 Use regalloc constraints for sse blen...

Wasmtime GitHub notifications bot (Nov 10 2022 at 23:44):

elliottt opened PR #5251 from trevor/sse-blend-pinned-regs to main:

Instead of always using xmm0, use regalloc constraints to constrain the mask register for the sse blend operations.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 10 2022 at 23:45):

elliottt updated PR #5251 from trevor/sse-blend-pinned-regs to main.

Wasmtime GitHub notifications bot (Nov 11 2022 at 02:00):

elliottt updated PR #5251 from trevor/sse-blend-pinned-regs to main.

Wasmtime GitHub notifications bot (Nov 11 2022 at 02:01):

elliottt has marked PR #5251 as ready for review.

Wasmtime GitHub notifications bot (Nov 11 2022 at 02:02):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 11 2022 at 02:02):

elliottt created PR review comment:

Another option here would be to use an Option<Xmm> field on XmmRmR. Happy to rework with that approach if the additional constructor here seems like too much.

Wasmtime GitHub notifications bot (Nov 11 2022 at 02:08):

elliottt updated PR #5251 from trevor/sse-blend-pinned-regs to main.

Wasmtime GitHub notifications bot (Nov 11 2022 at 02:10):

elliottt updated PR #5251 from trevor/sse-blend-pinned-regs to main.

Wasmtime GitHub notifications bot (Nov 11 2022 at 04:31):

elliottt updated PR #5251 from trevor/sse-blend-pinned-regs to main.

Wasmtime GitHub notifications bot (Nov 11 2022 at 04:37):

elliottt edited PR #5251 from trevor/sse-blend-pinned-regs to main:

Instead of using xmm0 explicitly for the mask argument to instructions like blendpd, use regalloc constraints to constrain it to xmm0 instead.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 11 2022 at 04:38):

elliottt edited PR #5251 from trevor/sse-blend-pinned-regs to main:

Instead of using xmm0 explicitly for the mask argument to instructions like blendvpd, use regalloc constraints to constrain it to xmm0 instead.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 14 2022 at 17:02):

elliottt requested fitzgen for a review on PR #5251.

Wasmtime GitHub notifications bot (Nov 14 2022 at 18:06):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 14 2022 at 18:06):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Nov 14 2022 at 18:06):

jameysharp created PR review comment:

Should this comment also be deleted now? If I'm reading the surrounding context correctly, I think xmm0 was the last thing the comment referred to.

Wasmtime GitHub notifications bot (Nov 14 2022 at 22:20):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 14 2022 at 22:20):

elliottt created PR review comment:

Yep, thanks for catching that!

Wasmtime GitHub notifications bot (Nov 14 2022 at 22:21):

elliottt updated PR #5251 from trevor/sse-blend-pinned-regs to main.

Wasmtime GitHub notifications bot (Nov 15 2022 at 00:44):

elliottt merged PR #5251.

Last updated: Dec 23 2024 at 12:05 UTC