Stream: git-wasmtime

Topic: wasmtime / PR #5249 cranelift: Rework pinned register low...

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:07):

elliottt opened PR #5249 from trevor/rework-pinned-reg to main:

Rework pinned register lowering to avoid the use of pinned virtual registers, instead using the MovFromPReg and MovToPReg pseudo instructions.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:08):

elliottt updated PR #5249 from trevor/rework-pinned-reg to main.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:14):

elliottt has marked PR #5249 as ready for review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:14):

elliottt requested fitzgen for a review on PR #5249.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:18):

elliottt created PR review comment:

If this isn't removed, the result of MoveFromPReg with the pinned register is ignored, and the pinned register is used directly.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:18):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:18):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:18):

elliottt created PR review comment:

It's not clear to me why this test changed to use %rsi for the temporary, but that's what causes the new stack space.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:19):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:19):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:19):

fitzgen created PR review comment:

These docs are a copy paste that should be updated for the actual use of this instruction.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:19):

fitzgen created PR review comment:

Ditto

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:20):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:20):

elliottt created PR review comment:

Scratch that -- it's the first preferred register, and also a clobber with sysv64.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:26):

elliottt updated PR #5249 from trevor/rework-pinned-reg to main.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:27):

elliottt updated PR #5249 from trevor/rework-pinned-reg to main.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:27):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:27):

elliottt created PR review comment:

Thanks for catching that!

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:27):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:27):

elliottt created PR review comment:

Thanks for catching that!

Wasmtime GitHub notifications bot (Nov 11 2022 at 00:19):

elliottt merged PR #5249.

Last updated: Oct 23 2024 at 20:03 UTC