Stream: git-wasmtime

Topic: wasmtime / PR #5242 cranelift-isle: Misc sema cleanups

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 03:25):

jameysharp opened PR #5242 from isle-misc-cleanup to main:

This mostly amounts to factoring out duplicated code and turning various uses of unwrap_or_continue! into iterator chains.

This PR probably conflicts with at least one of my other pending PRs, hooray... I'll rebase whichever one gets approved last.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 03:25):

jameysharp requested elliottt for a review on PR #5242.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 17:55):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 20:35):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 20:35):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 20:35):

elliottt created PR review comment:

It was a little surprising that this change was equivalent until I noticed that translate_iflet unconditionally returned a Some result :)

view this post on Zulip Wasmtime GitHub notifications bot (Nov 11 2022 at 00:57):

jameysharp updated PR #5242 from isle-misc-cleanup to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 11 2022 at 00:58):

jameysharp has enabled auto merge for PR #5242.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 11 2022 at 01:53):

jameysharp merged PR #5242.

Last updated: Oct 23 2024 at 20:03 UTC