Stream: git-wasmtime

Topic: wasmtime / PR #5241 cranelift-isle: Helpers to get type/t...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 01:30):

jameysharp requested elliottt for a review on PR #5241.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 01:30):

jameysharp opened PR #5241 from isle-by-name to main:

This is a common pattern in sema, so factor it out.

Since this version uses intern instead of intern_mut, it might be a tiny bit faster when errors occur due to not writing names into maps then. When no error occurs, ISLE should do exactly the same work with or without this commit.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 17:51):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2022 at 17:51):

fitzgen merged PR #5241.


Last updated: Dec 23 2024 at 13:07 UTC