Stream: git-wasmtime

Topic: wasmtime / PR #5241 cranelift-isle: Helpers to get type/t...

Wasmtime GitHub notifications bot (Nov 10 2022 at 01:30):

jameysharp requested elliottt for a review on PR #5241.

Wasmtime GitHub notifications bot (Nov 10 2022 at 01:30):

jameysharp opened PR #5241 from isle-by-name to main:

This is a common pattern in sema, so factor it out.

Since this version uses intern instead of intern_mut, it might be a tiny bit faster when errors occur due to not writing names into maps then. When no error occurs, ISLE should do exactly the same work with or without this commit.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 10 2022 at 17:51):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 17:51):

fitzgen merged PR #5241.

Last updated: Nov 22 2024 at 16:03 UTC