Stream: git-wasmtime

Topic: wasmtime / PR #5238 winch: Prepare for an update to the `...

Wasmtime GitHub notifications bot (Nov 09 2022 at 21:05):

alexcrichton opened PR #5238 from prepare-winch-update to main:

This commit prepares the winch crate for updating wasm-tools, notably changing a bit about how the visitation of operators works. This moves the function body and wasm validator out of the CodeGen structure and into parameters threaded into the emission of the actual function.

Additionally the VisitOperator implementation was updated to remove the explicit calls to the validator, favoring instead a macro-generated solution to guarantee that all validation happens before any translation proceeds. This means that the VisitOperator for CodeGen impl is now infallible and the various methods have been inlined into the trait methods as well as removing the Result<_>.

Finally this commit updates translation to call validator.finish(..) which is required to perform the final validation steps of the function body.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 09 2022 at 23:07):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 11:19):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2022 at 20:01):

alexcrichton merged PR #5238.

Last updated: Nov 22 2024 at 16:03 UTC