Stream: git-wasmtime

Topic: wasmtime / PR #5233 cranelift-isle: if-let patterns aren'...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2022 at 01:59):

jameysharp requested cfallin for a review on PR #5233.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2022 at 01:59):

jameysharp opened PR #5233 from isle-fix-iflet to main:

The is_root flag to translate_pattern just determines whether the rule_term argument is used, which begs a larger cleanup. But that cleanup is less clear if is_root is set anywhere aside from the call in collect_rules. So I wanted to get confirmation that this particular use of that flag is incorrect first.

These two arguments (is_root and rule_term) are used to prevent expansion of a term as an internal extractor ("macro") if:

I'm not sure what it should mean to use the term you're currently defining as the root pattern on the left-hand side of an if-let in the same rule, but I don't think it should have this particular special treatment.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2022 at 23:29):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2022 at 23:32):

jameysharp merged PR #5233.


Last updated: Dec 23 2024 at 12:05 UTC