jameysharp opened PR #5232 from isle-dedup-lookup
to main
:
While checking the call graph of extractors during semantic validation, save
TermId
instead ofSym
. The types are both just integer indexes, but theTermId
is more useful here. Saving it avoids needing to check for failed map lookups twice, which simplifies the implementation.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
jameysharp requested fitzgen for a review on PR #5232.
fitzgen submitted PR review.
jameysharp merged PR #5232.
Last updated: Dec 23 2024 at 12:05 UTC