Stream: git-wasmtime

Topic: wasmtime / PR #5232 cranelift-isle: Do fewer term lookups

Wasmtime GitHub notifications bot (Nov 09 2022 at 01:24):

jameysharp opened PR #5232 from isle-dedup-lookup to main:

While checking the call graph of extractors during semantic validation, save TermId instead of Sym. The types are both just integer indexes, but the TermId is more useful here. Saving it avoids needing to check for failed map lookups twice, which simplifies the implementation.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 09 2022 at 01:24):

jameysharp requested fitzgen for a review on PR #5232.

Wasmtime GitHub notifications bot (Nov 09 2022 at 18:03):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 09 2022 at 19:24):

jameysharp merged PR #5232.

Last updated: Nov 22 2024 at 17:03 UTC