Wasmtime GitHub notifications bot (Nov 08 2022 at 18:08): Wasmtime GitHub notifications bot (Nov 08 2022 at 18:08):cfallin opened PR #5226 from remove-x86-32-isms to main:
I was recently pointed to fastly/Viceroy#200 where it seems some folks are trying to compile Wasmtime (via Viceroy) for Windows x86-32 and the failures may not be loud enough. I've tried to reproduce this cross-compiling to i686-pc-windows-gnu from Linux and hit build failures (as expected) in several places. Nevertheless, while trying to discern what others may be attempting, I noticed some dead x86-32-specific code in our repo, and figured it would be a good idea to clean this up. Otherwise, it (i) sends some mixed messages -- "hey look, this codebase does support x86-32" -- and (ii) keeps untested code around, which is generally not great.
This PR removes x86-32-specific cases in traphandlers and unwind code, and Cranelift's native feature detection. It adds helpful compile-error messages in a few cases. If we ever support x86-32 (contributors welcome! The big missing piece is Cranelift support; see #1980), these compile errors and git history should be enough to recover any knowledge we are now encoding in the source.
I left the x86-32 support in
wasmtime-fiberalone because that seems like a bit of a special case -- foundation library, separate from the rest of Wasmtime, with specific care to provide a (presumably working) full 32-bit version.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 08 2022 at 18:08):cfallin requested pchickey for a review on PR #5226.
Wasmtime GitHub notifications bot (Nov 08 2022 at 18:09):cfallin updated PR #5226 from remove-x86-32-isms to main.
Wasmtime GitHub notifications bot (Nov 08 2022 at 18:49):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Nov 08 2022 at 21:52):cfallin updated PR #5226 from remove-x86-32-isms to main.
Wasmtime GitHub notifications bot (Nov 08 2022 at 21:52):cfallin has enabled auto merge for PR #5226.
Wasmtime GitHub notifications bot (Nov 08 2022 at 23:03):cfallin merged PR #5226.
Last updated: Nov 22 2024 at 17:03 UTC