Stream: git-wasmtime

Topic: wasmtime / PR #5222 Add a VRegAllocator to abstract over ...

Wasmtime GitHub notifications bot (Nov 08 2022 at 05:17):

elliottt opened PR #5222 from trevor/vreg-allocator to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 08 2022 at 05:34):

elliottt updated PR #5222 from trevor/vreg-allocator to main.

Wasmtime GitHub notifications bot (Nov 08 2022 at 05:35):

elliottt edited PR #5222 from trevor/vreg-allocator to main:

Remove the dependency on VCode for VReg allocation. This will simplify the changes in #5172, as that PR introduces the need to allocate temporary registers from the ABI context.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 08 2022 at 05:38):

elliottt edited PR #5222 from trevor/vreg-allocator to main:

Remove the dependency on VCode for VReg allocation. This will simplify the changes in #5172, as that PR introduces the need to allocate temporary registers from the ABI context.

This change also allows us to remove some fields from VCode: reftyped_vregs_set and have_ref_values. Additionally, the vcode_types field appears to be only used for its length after the VCode is built, so we could probably replace that field with a u32 as well.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 08 2022 at 05:38):

elliottt has marked PR #5222 as ready for review.

Wasmtime GitHub notifications bot (Nov 08 2022 at 05:38):

elliottt requested cfallin for a review on PR #5222.

Last updated: Nov 22 2024 at 17:03 UTC