Stream: git-wasmtime

Topic: wasmtime / PR #5205 Refactor configuration for the poolin...

Wasmtime GitHub notifications bot (Nov 04 2022 at 18:36):

alexcrichton opened PR #5205 from refactor-pooling-config to main:

This commit changes the APIs in the wasmtime crate for configuring the pooling allocator. I plan on adding a few more configuration options in the near future and the current structure was feeling unwieldy for adding these new abstractions.

The previous struct-based API has been replaced with a builder-style API in a similar shape as to Config. This is done to help make it easier to add more configuration options in the future through adding more methods as opposed to adding more field which could break prior initializations.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 04 2022 at 18:36):

alexcrichton requested peterhuene for a review on PR #5205.

Wasmtime GitHub notifications bot (Nov 04 2022 at 18:45):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Nov 04 2022 at 18:54):

alexcrichton updated PR #5205 from refactor-pooling-config to main.

Wasmtime GitHub notifications bot (Nov 04 2022 at 19:09):

alexcrichton has enabled auto merge for PR #5205.

Wasmtime GitHub notifications bot (Nov 04 2022 at 20:06):

alexcrichton merged PR #5205.

Last updated: Nov 22 2024 at 17:03 UTC