Stream: git-wasmtime

Topic: wasmtime / PR #5194 offer function-level control over tra...

Wasmtime GitHub notifications bot (Nov 03 2022 at 20:49):

joeshaw opened PR #5194 from joeshaw/suppress-tracing to main:

This replaces the simple tracing boolean from the from_witx! macro
with a suppress_tracing value that can be set on a per-function basis.

The format is the same as the async value, so functions can either be
listed individually in braces or all tracing can be disabled with *.
Some identifiers in code were renamed for this reuse: AsyncFunctions
-> Functions and AsyncConfField -> FunctionField.

Examples:

wiggle::from_witx!({
    suppress_tracing: *,
    witx: ["..."],
});

wiggle::from_witx!({
    suppress_tracing: {
        module1::func,
        module2::another_func,
    },
    witx: ["..."],
});

Fixes #5193

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 03 2022 at 20:58):

pchickey requested pchickey for a review on PR #5194.

Wasmtime GitHub notifications bot (Nov 04 2022 at 17:42):

joeshaw updated PR #5194 from joeshaw/suppress-tracing to main.

Wasmtime GitHub notifications bot (Nov 04 2022 at 17:43):

joeshaw edited PR #5194 from joeshaw/suppress-tracing to main:

This adds to the tracing boolean from the from_witx! macro a disabled_for list of identifiers that allow for suppression of tracing on a per-function basis.

Example:

wiggle::from_witx!({
    tracing: true disable_for {
        module1::func,
        module2::another_func,
    },
    witx: ["..."],
});

Fixes #5193

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 04 2022 at 19:03):

joeshaw has marked PR #5194 as ready for review.

Wasmtime GitHub notifications bot (Nov 05 2022 at 17:51):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Nov 05 2022 at 18:31):

pchickey merged PR #5194.

Last updated: Dec 23 2024 at 12:05 UTC