Wasmtime GitHub notifications bot (Nov 03 2022 at 19:29): Wasmtime GitHub notifications bot (Nov 03 2022 at 19:29):uweigand opened PR #5191 from bitselect-vselect-opt to main:
The simplifier was performing an optimization to replace bitselect with vselect if the all bytes of the condition mask could be shown to be all ones or all zeros.
This optimization only ever made any difference in codegen on the x64 target. Therefore, move this optimization to the x64 back-end and perform it in ISLE instead. Resulting codegen should be unchanged, with slightly improved compile time.
This also eliminates a few endian-dependent bitcast operations.
CC @cfallin
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 03 2022 at 20:09):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Nov 03 2022 at 20:09):cfallin has enabled auto merge for PR #5191.
Wasmtime GitHub notifications bot (Nov 03 2022 at 20:17):cfallin merged PR #5191.
Last updated: Nov 22 2024 at 17:03 UTC