Stream: git-wasmtime

Topic: wasmtime / PR #5187 cranelift: Rename `i{min,max}` to `s{...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 15:01):

afonso360 opened PR #5187 from rename-imin-imax to main:

:wave: Hey,

This brings these instructions in line with our general naming convention of signed instructions being prefixed with an s. The matching u{min,max} instructions already follow this convention.

The only other instructions that I could find that break this naming convention are iadd_{carry,cout}/isub_{borrow,bin}, which are discussed in: #5165

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 16:57):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 17:08):

afonso360 updated PR #5187 from rename-imin-imax to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 17:32):

jameysharp has enabled auto merge for PR #5187.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 18:20):

jameysharp merged PR #5187.

Last updated: Dec 06 2025 at 06:05 UTC