afonso360 opened PR #5177 from aarch64-cout
to main
:
:wave: Hey,
This PR adds lowerings for
iadd_cout
on the aarch64 backend.It's based on #5176 since it found an existing bug with the interpreter. But I've opened that as a separate PR so that its easier to review.
It also adds
iadd_cout
in the fuzzer and has been fuzzing for the past hour without issues.
afonso360 submitted PR review.
afonso360 created PR review comment:
I couldn't find a way to do this with the current
with_flags
mechanism, it looks like it can only return at most two registers, but I need the result of all three.Is there a better way of doing it?
fitzgen submitted PR review.
fitzgen submitted PR review.
fitzgen created PR review comment:
You should be able to define an
output_trio
extern constructor, the same way thatoutput_pair
is defined incranelift/codegen/src/machinst/isle.rs
andcranelift/codegen/src/prelude_lower.isle
.
fitzgen created PR review comment:
Can you add a little documentation here about how this is different from plain
cset
and why one would use it instead?
fitzgen created PR review comment:
Alternatively, if you don't want to deal with that at the moment, we could hold off on
i128
support for now.But yeah, there should never be raw
emit
calls in*/lower.isle
.
afonso360 updated PR #5177 from aarch64-cout
to main
.
jameysharp requested fitzgen for a review on PR #5177.
fitzgen submitted PR review.
fitzgen merged PR #5177.
Last updated: Dec 23 2024 at 12:05 UTC