Stream: git-wasmtime

Topic: wasmtime / PR #5177 cranelift: Add `iadd_cout` lowerings ...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 13:06):

afonso360 opened PR #5177 from aarch64-cout to main:

:wave: Hey,

This PR adds lowerings for iadd_cout on the aarch64 backend.

It's based on #5176 since it found an existing bug with the interpreter. But I've opened that as a separate PR so that its easier to review.

It also adds iadd_cout in the fuzzer and has been fuzzing for the past hour without issues.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 13:09):

afonso360 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 13:09):

afonso360 created PR review comment:

I couldn't find a way to do this with the current with_flags mechanism, it looks like it can only return at most two registers, but I need the result of all three.

Is there a better way of doing it?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 15 2022 at 18:23):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 15 2022 at 18:23):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 15 2022 at 18:23):

fitzgen created PR review comment:

You should be able to define an output_trio extern constructor, the same way that output_pair is defined in cranelift/codegen/src/machinst/isle.rs and cranelift/codegen/src/prelude_lower.isle.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 15 2022 at 18:23):

fitzgen created PR review comment:

Can you add a little documentation here about how this is different from plain cset and why one would use it instead?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 15 2022 at 18:23):

fitzgen created PR review comment:

Alternatively, if you don't want to deal with that at the moment, we could hold off on i128 support for now.

But yeah, there should never be raw emit calls in */lower.isle.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 24 2022 at 18:02):

afonso360 updated PR #5177 from aarch64-cout to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2022 at 02:06):

jameysharp requested fitzgen for a review on PR #5177.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2022 at 18:58):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2022 at 18:58):

fitzgen merged PR #5177.

Last updated: Nov 22 2024 at 16:03 UTC