Stream: git-wasmtime

Topic: wasmtime / PR #5171 cranelift-isle: trie construction and...

Wasmtime GitHub notifications bot (Nov 01 2022 at 21:48):

jameysharp opened PR #5171 from isle-cleanups to main:

One big change here is to stop using Term::extractor_sig, which was the only call that used a TypeEnv. However that function only uses type information to construct the fully-qualified name of the extractor, which is not used when building the IR. So removing it and removing the now-unused typeenv parameters removes all uses of TypeEnv from the ir and trie modules.

In addition, this completes the changes started in "More consistent use of add_inst" (e63771f2d921cdce440620dbf38bd3e186747b1e), by always using add_inst to get an InstId.

I also removed a number of unnecessary intermediate allocations.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 01 2022 at 21:48):

jameysharp requested fitzgen for a review on PR #5171.

Wasmtime GitHub notifications bot (Nov 01 2022 at 23:40):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 02 2022 at 00:17):

jameysharp merged PR #5171.

Last updated: Dec 23 2024 at 12:05 UTC