Stream: git-wasmtime

Topic: wasmtime / PR #5164 Remove the need for count_operands by...

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:12):

elliottt opened PR #5164 from trevor/remove-count-operands to main:

Remove the need for count_operands by restructuring emit in the s390x backend to instead take the AllocationConsumer as an argument.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:14):

elliottt updated PR #5164 from trevor/remove-count-operands to main.

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:15):

elliottt edited PR #5164 from trevor/remove-count-operands to main:

Remove the need for count_operands by restructuring emit in the s390x backend to instead take the AllocationConsumer as an argument.

cc @uweigand

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:15):

elliottt has marked PR #5164 as ready for review.

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:31):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:31):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:31):

cfallin created PR review comment:

Could we call this emit_with_alloc_consumer or something like that?

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:53):

elliottt updated PR #5164 from trevor/remove-count-operands to main.

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:54):

elliottt updated PR #5164 from trevor/remove-count-operands to main.

Wasmtime GitHub notifications bot (Nov 01 2022 at 04:56):

elliottt updated PR #5164 from trevor/remove-count-operands to main.

Wasmtime GitHub notifications bot (Nov 01 2022 at 16:54):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Nov 01 2022 at 17:05):

elliottt merged PR #5164.

Last updated: Nov 22 2024 at 16:03 UTC