Stream: git-wasmtime

Topic: wasmtime / PR #5164 Remove the need for count_operands by...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:12):

elliottt opened PR #5164 from trevor/remove-count-operands to main:

Remove the need for count_operands by restructuring emit in the s390x backend to instead take the AllocationConsumer as an argument.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:14):

elliottt updated PR #5164 from trevor/remove-count-operands to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:15):

elliottt edited PR #5164 from trevor/remove-count-operands to main:

Remove the need for count_operands by restructuring emit in the s390x backend to instead take the AllocationConsumer as an argument.

cc @uweigand

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:15):

elliottt has marked PR #5164 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:31):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:31):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:31):

cfallin created PR review comment:

Could we call this emit_with_alloc_consumer or something like that?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:53):

elliottt updated PR #5164 from trevor/remove-count-operands to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:54):

elliottt updated PR #5164 from trevor/remove-count-operands to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 04:56):

elliottt updated PR #5164 from trevor/remove-count-operands to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 16:54):

uweigand submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 17:05):

elliottt merged PR #5164.


Last updated: Dec 23 2024 at 12:05 UTC