Stream: git-wasmtime

Topic: wasmtime / PR #5162 Remove trapif and trapff

Wasmtime GitHub notifications bot (Oct 31 2022 at 21:41):

elliottt opened PR #5162 from trevor/remove-trap-iflags-instructions to main:

WIP.

This branch removes the trapif and trapff instructions, in favor of using an explicit comparison and trapnz. This moves us closer to removing iflags and fflags, but introduces the need to implement instructions like iadd_cout in the x64 and aarch64 backends.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 01 2022 at 23:53):

elliottt updated PR #5162 from trevor/remove-trap-iflags-instructions to main.

Wasmtime GitHub notifications bot (Nov 02 2022 at 16:02):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Nov 02 2022 at 16:02):

uweigand created PR review comment:

The part of the comment starting here should still be kept - the new uadd_overflow_trap still uses the condition code mask described here. The comment should probably just be moved there.

Wasmtime GitHub notifications bot (Nov 02 2022 at 23:19):

elliottt edited PR #5162 from trevor/remove-trap-iflags-instructions to main:

This branch removes the trapif and trapff instructions, in favor of using an explicit comparison and trapnz. This moves us closer to removing iflags and fflags, but introduces the need to implement instructions like iadd_cout in the x64 and aarch64 backends.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Nov 02 2022 at 23:19):

elliottt has marked PR #5162 as ready for review.

Wasmtime GitHub notifications bot (Nov 02 2022 at 23:54):

elliottt updated PR #5162 from trevor/remove-trap-iflags-instructions to main.

Wasmtime GitHub notifications bot (Nov 02 2022 at 23:54):

elliottt requested uweigand for a review on PR #5162.

Wasmtime GitHub notifications bot (Nov 03 2022 at 09:25):

uweigand submitted PR review.

Wasmtime GitHub notifications bot (Nov 03 2022 at 16:16):

elliottt requested fitzgen for a review on PR #5162.

Wasmtime GitHub notifications bot (Nov 03 2022 at 16:27):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 03 2022 at 16:27):

elliottt merged PR #5162.

Last updated: Oct 23 2024 at 20:03 UTC