Stream: git-wasmtime

Topic: wasmtime / PR #5162 Remove trapif and trapff


view this post on Zulip Wasmtime GitHub notifications bot (Oct 31 2022 at 21:41):

elliottt opened PR #5162 from trevor/remove-trap-iflags-instructions to main:

WIP.

This branch removes the trapif and trapff instructions, in favor of using an explicit comparison and trapnz. This moves us closer to removing iflags and fflags, but introduces the need to implement instructions like iadd_cout in the x64 and aarch64 backends.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 01 2022 at 23:53):

elliottt updated PR #5162 from trevor/remove-trap-iflags-instructions to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 16:02):

uweigand submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 16:02):

uweigand created PR review comment:

The part of the comment starting here should still be kept - the new uadd_overflow_trap still uses the condition code mask described here. The comment should probably just be moved there.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 23:19):

elliottt edited PR #5162 from trevor/remove-trap-iflags-instructions to main:

This branch removes the trapif and trapff instructions, in favor of using an explicit comparison and trapnz. This moves us closer to removing iflags and fflags, but introduces the need to implement instructions like iadd_cout in the x64 and aarch64 backends.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 23:19):

elliottt has marked PR #5162 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 23:54):

elliottt updated PR #5162 from trevor/remove-trap-iflags-instructions to main.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2022 at 23:54):

elliottt requested uweigand for a review on PR #5162.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 09:25):

uweigand submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 16:16):

elliottt requested fitzgen for a review on PR #5162.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 16:27):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2022 at 16:27):

elliottt merged PR #5162.


Last updated: Dec 23 2024 at 13:07 UTC