Stream: git-wasmtime

Topic: wasmtime / PR #5153 Refactor metadata storage in AOT arti...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2022 at 21:11):

alexcrichton opened PR #5153 from refactor-compilation-metadata to main:

This commit is a reorganization of how metadata is stored in Wasmtime's compiled artifacts. Currently Wasmtime's ELF artifacts have data appended after them to contain metadata about the Engine as well as type information for the module itself. This extra data at the end of the file is ignored by ELF-related utilities generally and is assembled during the module serialization process.

In working on AOT-compiling components, though, I've discovered a number of issues with this:

To solve these issues this commit splits up the
module/serialization.rs file in two, mostly moving the logic to engine/serialization.rs. The engine serialization logic now handles everything related to Engine compatibility such as targets, compiler flags, wasm features, etc. The module serialization logic is now exclusively interested in type information.

The engine metadata and serialized type information additionally live in sections of the final file now instead of at the end. This means that there are three primary bincode-encoded sections that are parsed on deserializing a file:

  1. The Engine-specific metadata. This will be the same for both modules and components.
  2. The CompiledModuleInfo structure. For core wasm there's just one of these but for the component model there will be multiple, one per core wasm module.
  3. The type information. For core wasm this is a ModuleTypes but for a component this will be a ComponentTypes.

No true functional change is expected from this commit. Binary artifacts might get inflated by a small handful of bytes due to using ELF sections to represent this now.

A related change I made during this commit as well was the plumbing of the is_branch_protection_enabled flag. This is technically Engine-level metadata but I didn't want to plumb it all over the place as was done now, so instead a new section was added to the final binary just for this bti information. This means that it no longer needs to be a parameter to CodeMemory::publish and additionally is more amenable to a Component-is-just-one-object world where no single module owns this piece of metadata.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2022 at 21:11):

alexcrichton requested pchickey for a review on PR #5153.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2022 at 23:15):

pchickey submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2022 at 16:35):

alexcrichton updated PR #5153 from refactor-compilation-metadata to main.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2022 at 17:01):

alexcrichton has enabled auto merge for PR #5153.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 29 2022 at 17:13):

alexcrichton merged PR #5153.


Last updated: Dec 23 2024 at 12:05 UTC