Wasmtime GitHub notifications bot (Oct 27 2022 at 17:09): Wasmtime GitHub notifications bot (Oct 27 2022 at 17:09):pchickey opened PR #5146 from pch/optional-wiggle-tracing to main:
Wiggle generates code that instruments APIs with tracing code. This is handy for diagnosing issues at runtime, but when inspecting the output of Wiggle, it can make the generated code difficult for a human to decipher. This change makes tracing a default but optional feature, allowing users to avoid tracing code with commands like
cargo expand --no-default-features. This should be no change for current crates depending onwiggle,wiggle-macro, andwiggle-generate.review: add 'tracing' feature to wasi-common
review: switch to using macro configuration parsing
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 27 2022 at 17:25):pchickey has marked PR #5146 as ready for review.
Wasmtime GitHub notifications bot (Oct 27 2022 at 17:53):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 27 2022 at 18:26):pchickey merged PR #5146.
Last updated: Oct 23 2024 at 20:03 UTC