Stream: git-wasmtime

Topic: wasmtime / PR #5140 Cleanup wasmi fuzzing code

Wasmtime GitHub notifications bot (Oct 27 2022 at 15:28):

Robbepop edited PR #5140 from rf-cleanup-wasmi-fuzzer to main:

Just some minor clean ups to the wasmi fuzzer code.
Unfortunately due to compilation/linkage problems with the OCaml based spec interpreter I could not run the fuzz tests locally so there might be bugs that I have to fix ... :/

Can we run fuzz tests via CI?

Wasmtime GitHub notifications bot (Oct 27 2022 at 15:46):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 15:46):

jameysharp created PR review comment:

Does this work? I like having a separate unwrap for each failure case so they generate different panic messages. (rustfmt will probably disagree with my formatting, I'm just typing in the GitHub web UI here.)

        Some(self.instance
            .get_export(&self.store, name)
            .unwrap()
            .into_global()
            .unwrap()
            .get(&self.store)
            .into())

If that works, I'd do the same in get_memory and at the top of evaluate.

Wasmtime GitHub notifications bot (Oct 27 2022 at 15:46):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 15:48):

Robbepop created PR review comment:

haha this actually looks even cleaner to me somehow ... :sweat_smile: will apply those changes to both sites

Wasmtime GitHub notifications bot (Oct 27 2022 at 15:48):

Robbepop submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 15:48):

Robbepop edited PR review comment.

Wasmtime GitHub notifications bot (Oct 27 2022 at 16:26):

Robbepop updated PR #5140 from rf-cleanup-wasmi-fuzzer to main.

Wasmtime GitHub notifications bot (Oct 27 2022 at 17:18):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 17:18):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 17:18):

jameysharp created PR review comment:

I just noticed, I think you meant to call this function "trap_code" rather than "tap_code".

Wasmtime GitHub notifications bot (Oct 27 2022 at 17:18):

jameysharp created PR review comment:

Does rustfmt insist on a trailing comma here or can you delete that?

Wasmtime GitHub notifications bot (Oct 27 2022 at 17:18):

jameysharp created PR review comment:

I'd suggest the same multi-unwrap pattern here too:

            .unwrap()
            .into_func()
            .unwrap();

Wasmtime GitHub notifications bot (Oct 27 2022 at 17:20):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 17:20):

jameysharp created PR review comment:

According to CI, rustfmt is insisting on adding a trailing comma to the other use of Some. So I guess that answers my question, although not in the direction I was hoping for :sweat_smile:

Wasmtime GitHub notifications bot (Oct 27 2022 at 18:29):

Robbepop updated PR #5140 from rf-cleanup-wasmi-fuzzer to main.

Wasmtime GitHub notifications bot (Oct 29 2022 at 07:35):

Robbepop updated PR #5140 from rf-cleanup-wasmi-fuzzer to main.

Wasmtime GitHub notifications bot (Oct 29 2022 at 07:35):

Robbepop submitted PR review.

Wasmtime GitHub notifications bot (Oct 29 2022 at 07:35):

Robbepop created PR review comment:

good find! fixed it

Wasmtime GitHub notifications bot (Oct 30 2022 at 08:51):

Robbepop updated PR #5140 from rf-cleanup-wasmi-fuzzer to main.

Wasmtime GitHub notifications bot (Oct 31 2022 at 19:41):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Oct 31 2022 at 19:42):

jameysharp merged PR #5140.

Last updated: Nov 22 2024 at 16:03 UTC