Stream: git-wasmtime

Topic: wasmtime / PR #5137 wiggle: make wasmtime a mandatory dep...

Wasmtime GitHub notifications bot (Oct 26 2022 at 20:57):

pchickey opened PR #5137 from pch/wiggle_wasmtime_mandatory to main:

Wiggle (& wasi-common) did a fair bit of cargo feature & other gymnastics to support Lucet and Wasmtime simultaneously. Supporting Lucet is no longer a concern, so I erased the cargo features that made wasmtime support optional in these crates, and got rid of the intermediate wiggle::Trap enum, using wasmtime::Trap directly instead.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 26 2022 at 21:30):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 26 2022 at 22:22):

pchickey updated PR #5137 from pch/wiggle_wasmtime_mandatory to main.

Wasmtime GitHub notifications bot (Oct 26 2022 at 22:25):

pchickey updated PR #5137 from pch/wiggle_wasmtime_mandatory to main.

Wasmtime GitHub notifications bot (Oct 26 2022 at 22:35):

pchickey edited PR #5137 from pch/wiggle_wasmtime_mandatory to main:

Wiggle (& wasi-common) did a fair bit of cargo feature & other gymnastics to support Lucet and Wasmtime simultaneously. Supporting Lucet is no longer a concern, so I erased the cargo features that made wasmtime support optional in these crates, and got rid of the intermediate wiggle::Trap enum, using wasmtime::Trap directly instead.

Note this means wasi-common will no longer build for wasm32-unknown-emscripten because it depends on wasmtime. It used to build for that target to support a web polyfill, but we haven't maintained that polyfill in years and are fine with dropping that support.

Wasmtime GitHub notifications bot (Oct 26 2022 at 23:31):

pchickey updated PR #5137 from pch/wiggle_wasmtime_mandatory to main.

Wasmtime GitHub notifications bot (Oct 26 2022 at 23:31):

pchickey edited PR #5137 from pch/wiggle_wasmtime_mandatory to main:

Wiggle (& wasi-common) did a fair bit of cargo feature & other gymnastics to support Lucet and Wasmtime simultaneously. Supporting Lucet is no longer a concern, so I erased the cargo features that made wasmtime support optional in these crates, and got rid of the intermediate wiggle::Trap enum, using wasmtime::Trap directly instead.

Note this means wasi-common will no longer build for wasm32-unknown-emscripten nor armv7-unknown-linux because it depends on wasmtime. The emscripten used to build for that target to support a web polyfill, but we haven't maintained that polyfill in years and are fine with dropping that support. I have no idea what the armv7 target was used for.

Wasmtime GitHub notifications bot (Oct 26 2022 at 23:32):

pchickey edited PR #5137 from pch/wiggle_wasmtime_mandatory to main:

Wiggle (& wasi-common) did a fair bit of cargo feature & other gymnastics to support Lucet and Wasmtime simultaneously. Supporting Lucet is no longer a concern, so I erased the cargo features that made wasmtime support optional in these crates, and got rid of the intermediate wiggle::Trap enum, using wasmtime::Trap directly instead.

Note this means wasi-common will no longer build for wasm32-unknown-emscripten nor armv7-unknown-linux because it depends on wasmtime. The emscripten used to build for that target to support a web polyfill, but we haven't maintained that polyfill in years and are fine with dropping that support. I have no idea what the armv7 target was used for. These targets were enforced in CI for a long time, and I deleted the CI job that checks for them.

Wasmtime GitHub notifications bot (Oct 26 2022 at 23:35):

pchickey edited PR #5137 from pch/wiggle_wasmtime_mandatory to main:

Wiggle (& wasi-common) did a fair bit of cargo feature & other gymnastics to support Lucet and Wasmtime simultaneously. Supporting Lucet is no longer a concern, so I erased the cargo features that made wasmtime support optional in these crates, and got rid of the intermediate wiggle::Trap enum, using wasmtime::Trap directly instead.

Note this means wasi-common will no longer build for wasm32-unknown-emscripten nor armv7-unknown-linux because it depends on wasmtime. The emscripten used to build for that target to support a web polyfill, but we haven't maintained that polyfill in years and are fine with dropping that support. I have no idea what the armv7 target was used for. These targets were enforced in CI for a long time, and I deleted the CI job that checks for them.

We will be adding component support to wasi-common shortly, which will also incur a direct wasmtime dep in that crate, so those targets were going to be broken pretty soon anyway. I hope that this doesn't cause too much grief for anyone.

Wasmtime GitHub notifications bot (Oct 27 2022 at 14:41):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 16:28):

pchickey merged PR #5137.

Last updated: Dec 23 2024 at 12:05 UTC