Stream: git-wasmtime

Topic: wasmtime / PR #5135 Add a missing compilation feature for...

Wasmtime GitHub notifications bot (Oct 26 2022 at 19:19):

alexcrichton opened PR #5135 from fix-windows-build to main:

This fixes a compilation error on Windows when just the wasmtime crate is compiled. If the async feature and wasi-common are omitted then otherwise this feature was accidentally not included. This was not caught on our CI only performs these minimal build checks on Linux, not on Windows as well.

Closes #5133

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 26 2022 at 19:20):

alexcrichton closed without merge PR #5135.

Last updated: Nov 22 2024 at 17:03 UTC