Stream: git-wasmtime

Topic: wasmtime / PR #5132 Generate more fixed_nonallocatable co...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 19 2022 at 09:13):

elliottt edited PR #5132 from trevor/ssa-assertions to main:

Add assertions to the OperandCollector that show we're not using pinned vregs, and use reg_fixed_nonallocatable constraints when a real register is used with other constraint generation functions like reg_use etc.

I experimented with adding debug assertions that the reused operand referenced in reg_reuse_def constraints was compatible with the new constraint that would be generated. This didn't end up being possible as some backends will recursively process instructions when collecting operands, making it impossible without more invasive changes to tell where that operand is in the operand vector. Given that we would need to plumb through somewhat substantial changes to support adding debug assertions, I decided that rephrasing the existing warning comment about real registers would be good enough.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 19 2022 at 09:14):

elliottt edited PR #5132 from trevor/ssa-assertions to main:

Add assertions to the OperandCollector that show we're not using pinned vregs, and use reg_fixed_nonallocatable constraints when a real register is used with other constraint generation functions like reg_use etc.

I experimented with adding debug assertions that the reused operand referenced in reg_reuse_def constraints was compatible with the new constraint that would be generated. This didn't end up being possible as some backends will recursively process instructions when collecting operands, making it impossible without more invasive changes to tell where that operand is in the operand vector. Given that we would need to plumb through somewhat substantial changes to support adding debug assertions, I decided that rephrasing the existing warning comment about real registers would be good enough.
<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Nov 19 2022 at 09:15):

elliottt has marked PR #5132 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 28 2022 at 17:29):

elliottt requested cfallin for a review on PR #5132.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 28 2022 at 17:55):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 28 2022 at 18:31):

elliottt merged PR #5132.


Last updated: Dec 23 2024 at 12:05 UTC