Stream: git-wasmtime

Topic: wasmtime / PR #5129 cranelift: Implement `ineg.i128` for ...

Wasmtime GitHub notifications bot (Oct 26 2022 at 12:02):

afonso360 opened PR #5129 from ineg to main:

:wave: Hey,

This PR implements ineg.i128 for all backends, except s390x which already supports it.

Fixes #5108
Fixes #5105

Wasmtime GitHub notifications bot (Oct 27 2022 at 15:35):

afonso360 updated PR #5129 from ineg to main.

Wasmtime GitHub notifications bot (Oct 27 2022 at 19:24):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 19:24):

cfallin created PR review comment:

We unfortunately can't do this (right now) because the zero reg is not allocatable (and if it were, we are also working on removing "pinned vregs", where a vreg refers to a specific physical reg always); @elliottt is working on using fixed-reg operands to allow this in a better way. For now, can we use (imm $I64 0) for zeroes (and then we can apply the "use zero reg for a zero" optimization in one place later)?

Wasmtime GitHub notifications bot (Oct 27 2022 at 19:24):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2022 at 19:24):

cfallin created PR review comment:

Likewise here as above

Wasmtime GitHub notifications bot (Oct 28 2022 at 08:36):

afonso360 updated PR #5129 from ineg to main.

Wasmtime GitHub notifications bot (Oct 28 2022 at 19:13):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 28 2022 at 20:57):

afonso360 updated PR #5129 from ineg to main.

Wasmtime GitHub notifications bot (Oct 28 2022 at 23:10):

cfallin merged PR #5129.

Last updated: Dec 23 2024 at 12:05 UTC