Stream: git-wasmtime

Topic: wasmtime / PR #5125 cranelift: Remove `copy` instruction

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2022 at 21:03):

afonso360 opened PR #5125 from remove-copy to main:

:wave: Hey,

This it turned up when looking at list of missing instructions for the fuzzer. copy seems to not be used anymore, wasmtime does not use it, cg_clif does not use it, and the only use of it in the repository is in tests.

The docs for this instruction state:

this instruction is useful for representing intermediate stages during instruction transformations, and the register allocator needs a way of representing register copies.

But it seems that both of those are no longer true, right?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2022 at 21:13):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2022 at 00:27):

jameysharp submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 26 2022 at 00:27):

jameysharp merged PR #5125.

Last updated: Dec 23 2024 at 12:05 UTC