Stream: git-wasmtime

Topic: wasmtime / PR #5112 egraphs: fix fill-in-the-types logic ...

Wasmtime GitHub notifications bot (Oct 24 2022 at 21:44):

cfallin opened PR #5112 from fix-5099 to main:

Fixes #5099.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 24 2022 at 21:44):

cfallin requested elliottt for a review on PR #5112.

Wasmtime GitHub notifications bot (Oct 24 2022 at 21:44):

cfallin requested jameysharp for a review on PR #5112.

Wasmtime GitHub notifications bot (Oct 24 2022 at 22:09):

jameysharp submitted PR review.

Wasmtime GitHub notifications bot (Oct 25 2022 at 04:39):

cfallin updated PR #5112 from fix-5099 to main.

Wasmtime GitHub notifications bot (Oct 25 2022 at 04:41):

cfallin edited PR #5112 from fix-5099 to main:

In particular, this was found to happen in #5099 because a Result
projection node was not deduplicating across two separate isplits that
created it. (This is a separate issue we should also fix; needs_dedup
is I think overly conservative because Result can project out a single
value from a pure or impure node, but the projection itself should be
treated like any other pure operator.)

In any case, if we have a value v0 and two separate
Result { value: v0, result: N, ty } nodes, each of these will fill in the
type ty for the Nth output of v0, and the second will idempotently
overwrite the first; we should loosen the assert so that it allows this case.

Fixes #5099. Fixes #5100.

Wasmtime GitHub notifications bot (Oct 25 2022 at 04:42):

cfallin has enabled auto merge for PR #5112.

Wasmtime GitHub notifications bot (Oct 25 2022 at 04:43):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 25 2022 at 04:44):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 25 2022 at 05:22):

cfallin merged PR #5112.

Last updated: Dec 23 2024 at 12:05 UTC