fitzgen opened PR #5095 from compute-arg-locs-iterator
to main
:
Instead of slices. This gives us more flexibility to pass custom sequences without needing to allocate a
Vec
to hold them and pass in as a slice.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
fitzgen requested elliottt for a review on PR #5095.
fitzgen requested cfallin for a review on PR #5095.
elliottt created PR review comment:
Do you still need the
.copied()
here?
elliottt submitted PR review.
elliottt submitted PR review.
elliottt created PR review comment:
Ah, the
Item
is still a reference, never mind :)
fitzgen submitted PR review.
fitzgen created PR review comment:
Yeah because otherwise it is references to params, and the s390x needs the actual value because it will re-assign the
param
local elsewhere in the loop.
elliottt submitted PR review.
fitzgen merged PR #5095.
Last updated: Dec 23 2024 at 12:05 UTC