Stream: git-wasmtime

Topic: wasmtime / PR #5095 Cranelift: pass iterators to `ABIMach...

Wasmtime GitHub notifications bot (Oct 21 2022 at 20:38):

fitzgen opened PR #5095 from compute-arg-locs-iterator to main:

Instead of slices. This gives us more flexibility to pass custom sequences without needing to allocate a Vec to hold them and pass in as a slice.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 21 2022 at 20:38):

fitzgen requested elliottt for a review on PR #5095.

Wasmtime GitHub notifications bot (Oct 21 2022 at 20:38):

fitzgen requested cfallin for a review on PR #5095.

Wasmtime GitHub notifications bot (Oct 21 2022 at 21:22):

elliottt created PR review comment:

Do you still need the .copied() here?

Wasmtime GitHub notifications bot (Oct 21 2022 at 21:22):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 21 2022 at 21:24):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 21 2022 at 21:24):

elliottt created PR review comment:

Ah, the Item is still a reference, never mind :)

Wasmtime GitHub notifications bot (Oct 21 2022 at 21:45):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Oct 21 2022 at 21:45):

fitzgen created PR review comment:

Yeah because otherwise it is references to params, and the s390x needs the actual value because it will re-assign the param local elsewhere in the loop.

Wasmtime GitHub notifications bot (Oct 21 2022 at 23:00):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 21 2022 at 23:08):

fitzgen merged PR #5095.

Last updated: Nov 22 2024 at 16:03 UTC