Stream: git-wasmtime

Topic: wasmtime / PR #5094 Cranelift: use `.enumerate()` to avoi...

Wasmtime GitHub notifications bot (Oct 21 2022 at 18:49):

fitzgen opened PR #5094 from enumerate-rather-than-index to main:

This can help rustc/llvm avoid bounds checks, but more importantly I will have future changes here that remove indexing of params, and instead hand them out as an iterator.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 21 2022 at 18:49):

fitzgen requested cfallin for a review on PR #5094.

Wasmtime GitHub notifications bot (Oct 21 2022 at 19:02):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Oct 21 2022 at 20:08):

fitzgen merged PR #5094.

Last updated: Nov 22 2024 at 16:03 UTC