Stream: git-wasmtime

Topic: wasmtime / PR #5093 Cranelift: Remove duplicate IR signat...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2022 at 18:30):

fitzgen requested elliottt for a review on PR #5093.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2022 at 18:30):

fitzgen opened PR #5093 from extra-sig-legalization-calls to main:

The SigData::from_func_sig constructor will already ensure that the struct return pointer is returned, so this is a purely unnecessary call.

Note that this is not a performance speed up, since ensure_struct_return_ptr_is_returned doesn't do any significant work if the signature is already legalized.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2022 at 18:36):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2022 at 19:09):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2022 at 20:08):

fitzgen merged PR #5093.


Last updated: Dec 23 2024 at 12:05 UTC