Stream: git-wasmtime

Topic: wasmtime / PR #5092 s390x: use constraints for call argum...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2022 at 17:19):

uweigand opened PR #5092 from s390x-call-abi to main:

Use the regalloc constraint-based CallArgList / CallRetList mechanism instead of directly using physregs in instructions.

CC @cfallin @elliottt

Note that this patch continues to emit calls directly from ISLE. I tried to use the common gen_call, but that would require several extensions to properly support s390x:

Except for that last point, I have some implementation prototypes. But even so, the resulting code was of lower quality than what I get with the ISLE-based logic today - in particular, with the ISLE logic we can better fold incoming argument expressions (e.g. into sign extension, or into the address used for a memory copy instruction). Therefore I decided to stay with this approach.

The generated code remains the same except for register allocation and instruction scheduling differences.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2022 at 18:01):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2022 at 18:01):

cfallin merged PR #5092.


Last updated: Dec 23 2024 at 12:05 UTC