cfallin opened PR #5088 from fix-issue-5086
to main
:
This fixes #5086 by addressing two separate issues:
- The
ValueDataPacked::set_type()
helper had an embarrassing bitfield-manipulation bug that would mangle the rest of aValueDef
when setting its type. This is not normally used, only when the egraph elaboration fills in types after-the-fact on a multi-value node.- The lowering rules for
isplit
on aarch64 and s390x were dispatching on the first output type, rather than the input type. When only the second output is used (as in the example in #5086), the first output type actually remainsINVALID
(and this is fine because it's never used).
cfallin requested elliottt for a review on PR #5088.
cfallin requested fitzgen for a review on PR #5088.
elliottt submitted PR review.
elliottt submitted PR review.
elliottt created PR review comment:
Should we add s390x to this list?
cfallin updated PR #5088 from fix-issue-5086
to main
.
cfallin submitted PR review.
cfallin created PR review comment:
Sure, added!
cfallin merged PR #5088.
Last updated: Dec 23 2024 at 12:05 UTC