Wasmtime GitHub notifications bot (Oct 21 2022 at 02:44): Wasmtime GitHub notifications bot (Oct 21 2022 at 02:44):cfallin opened PR #5088 from fix-issue-5086 to main:
This fixes #5086 by addressing two separate issues:
- The
ValueDataPacked::set_type()helper had an embarrassing bitfield-manipulation bug that would mangle the rest of aValueDefwhen setting its type. This is not normally used, only when the egraph elaboration fills in types after-the-fact on a multi-value node.- The lowering rules for
ispliton aarch64 and s390x were dispatching on the first output type, rather than the input type. When only the second output is used (as in the example in #5086), the first output type actually remainsINVALID(and this is fine because it's never used).
Wasmtime GitHub notifications bot (Oct 21 2022 at 02:44):cfallin requested elliottt for a review on PR #5088.
Wasmtime GitHub notifications bot (Oct 21 2022 at 02:44):cfallin requested fitzgen for a review on PR #5088.
Wasmtime GitHub notifications bot (Oct 21 2022 at 16:27):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2022 at 16:27):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2022 at 16:27):elliottt created PR review comment:
Should we add s390x to this list?
Wasmtime GitHub notifications bot (Oct 21 2022 at 16:37):cfallin updated PR #5088 from fix-issue-5086 to main.
Wasmtime GitHub notifications bot (Oct 21 2022 at 16:38):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Oct 21 2022 at 16:38):cfallin created PR review comment:
Sure, added!
Wasmtime GitHub notifications bot (Oct 21 2022 at 17:24):cfallin merged PR #5088.
Last updated: Oct 23 2024 at 20:03 UTC