afonso360 opened PR #5075 from remove-iconst-i128
to main
:
:wave: Hey,
This is a fix for the issue that was discovered in #5046 where
iconst.i128
was causing issues and we decided to remove it.I think most of the codegen differences are different register selection, except for the x64 tests where it de-duplicated some zeroing of registers.
cc: @cfallin
afonso360 edited PR #5075 from remove-iconst-i128
to main
:
:wave: Hey,
This is a fix for the issue that was discovered in #5046 where
iconst.i128
was causing issues and we decided to remove it.I think most of the codegen differences are different register selection, except for the x64 tests where it de-duplicated some zeroing of registers.
Bugpoint also had to be updated to recognize the new pattern of
uextend+iconst
when minimizing these cases.cc: @cfallin
afonso360 updated PR #5075 from remove-iconst-i128
to main
.
cfallin submitted PR review.
afonso360 updated PR #5075 from remove-iconst-i128
to main
.
bjorn3 submitted PR review.
bjorn3 created PR review comment:
nit: missing trailing newline
afonso360 updated PR #5075 from remove-iconst-i128
to main
.
afonso360 updated PR #5075 from remove-iconst-i128
to main
.
bjorn3 submitted PR review.
bjorn3 created PR review comment:
This should work for i128 too, right?
afonso360 updated PR #5075 from remove-iconst-i128
to main
.
cfallin submitted PR review.
cfallin merged PR #5075.
Last updated: Dec 23 2024 at 12:05 UTC