Stream: git-wasmtime

Topic: wasmtime / PR #5075 cranelift: Remove `iconst.i128`

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2022 at 14:27):

afonso360 opened PR #5075 from remove-iconst-i128 to main:

:wave: Hey,

This is a fix for the issue that was discovered in #5046 where iconst.i128 was causing issues and we decided to remove it.

I think most of the codegen differences are different register selection, except for the x64 tests where it de-duplicated some zeroing of registers.

cc: @cfallin

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2022 at 14:30):

afonso360 edited PR #5075 from remove-iconst-i128 to main:

:wave: Hey,

This is a fix for the issue that was discovered in #5046 where iconst.i128 was causing issues and we decided to remove it.

I think most of the codegen differences are different register selection, except for the x64 tests where it de-duplicated some zeroing of registers.

Bugpoint also had to be updated to recognize the new pattern of uextend+iconst when minimizing these cases.

cc: @cfallin

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2022 at 14:56):

afonso360 updated PR #5075 from remove-iconst-i128 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 19 2022 at 18:07):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2022 at 14:33):

afonso360 updated PR #5075 from remove-iconst-i128 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2022 at 14:36):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2022 at 14:36):

bjorn3 created PR review comment:

nit: missing trailing newline

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2022 at 15:11):

afonso360 updated PR #5075 from remove-iconst-i128 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2022 at 16:04):

afonso360 updated PR #5075 from remove-iconst-i128 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2022 at 16:25):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2022 at 16:25):

bjorn3 created PR review comment:

This should work for i128 too, right?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 22 2022 at 17:19):

afonso360 updated PR #5075 from remove-iconst-i128 to main.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2022 at 19:43):

cfallin submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 24 2022 at 19:43):

cfallin merged PR #5075.

Last updated: Nov 22 2024 at 16:03 UTC