Wasmtime GitHub notifications bot (Oct 17 2022 at 06:13): Wasmtime GitHub notifications bot (Oct 17 2022 at 06:13):cfallin requested elliottt for a review on PR #5062.
Wasmtime GitHub notifications bot (Oct 17 2022 at 06:13):cfallin requested fitzgen for a review on PR #5062.
Wasmtime GitHub notifications bot (Oct 17 2022 at 06:13):cfallin opened PR #5062 from test-egraphs to main:
This change adds another variant of the spec-tests run as part of the
wasmtime-clicrate's unit tests: Cranelift with egraph-based optimizations enabled.We intend to test egraphs in various ways before turning the mechanism on by default. We will certainly fuzz differentially, but it is also useful to run our basic testsuite against the new compiler mid-end as part of normal CI. There is already precedent for running the spec tests with a variant of settings (the
_poolingversions of each test). The actual spec testsuite execution does not contribute appreciably to CI time compared to the time to compile Wasmtime itself, so running an extra variant of the tests should not increase test cost significantly.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 17 2022 at 19:49):cfallin closed without merge PR #5062.
Last updated: Oct 23 2024 at 20:03 UTC