Stream: git-wasmtime

Topic: wasmtime / PR #5061 egraph opts: fix uextend-of-i32.

Wasmtime GitHub notifications bot (Oct 17 2022 at 06:07):

cfallin opened PR #5061 from fix-iconst-egraph to main:

This is a simple error in the const-prop rules: uextend was not masking iconst's u64 immediate when extending from i32 to i64. Arguably an iconst.i32 should not have nonzero bits in the upper 32 of its immediate, but that's a separate design question. For now, if our invariant is that the upper bits are ignored, then it is required to mask the bits when const-evaling a uextend.

Fixes #5047.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 17 2022 at 06:07):

cfallin requested fitzgen for a review on PR #5061.

Wasmtime GitHub notifications bot (Oct 17 2022 at 06:07):

cfallin requested elliottt for a review on PR #5061.

Wasmtime GitHub notifications bot (Oct 17 2022 at 07:40):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Oct 17 2022 at 19:45):

cfallin merged PR #5061.

Last updated: Dec 23 2024 at 12:05 UTC