Stream: git-wasmtime

Topic: wasmtime / PR #5051 Ignore when components export type de...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2022 at 22:02):

pchickey opened PR #5051 from pch/stub_component_type_typedef_for_exports to main:

As of https://github.com/bytecodealliance/wit-bindgen/pull/369, wit-component will export interface types in order to give them names.

We now accept type for mapping to a component TypeDef in wasmtime-environ.

Type exports do not have definitions which Wasmtime can match to a Definition, so we now skip inspecting them in the component/matching.rs file.

A test case has been added to component-model/instance.wast.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2022 at 22:04):

pchickey requested alexcrichton for a review on PR #5051.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2022 at 22:25):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2022 at 22:25):

alexcrichton has enabled auto merge for PR #5051.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 12 2022 at 22:45):

alexcrichton merged PR #5051.

Last updated: Nov 22 2024 at 17:03 UTC