Stream: git-wasmtime

Topic: wasmtime / PR #5036 cranelift: Support `bnot`, `band`, `b...

Wasmtime GitHub notifications bot (Oct 11 2022 at 00:55):

ArtBlnd edited PR #5036 from x86_64-float-bitops1 to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

This patch implements float bitops on x86_64 using SSE instructions.
@afonso360

• [x] Check if better single slot bitops available on x86_64. (which has better latency or throughput?...)
• [ ] Make single slot mask for f32, f64 instead of vector_all_ones

Wasmtime GitHub notifications bot (Oct 17 2022 at 21:48):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Oct 22 2022 at 18:52):

ArtBlnd has marked PR #5036 as ready for review.

Wasmtime GitHub notifications bot (Oct 22 2022 at 18:52):

ArtBlnd edited PR #5036 from x86_64-float-bitops1 to main:

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

This patch implements float bitops on x86_64 using SSE instructions.
@afonso360

• [x] Check if better single slot bitops available on x86_64. (which has better latency or throughput?...)
• [x] Make single slot mask for f32, f64 instead of vector_all_ones

Wasmtime GitHub notifications bot (Oct 22 2022 at 19:07):

ArtBlnd updated PR #5036 from x86_64-float-bitops1 to main.

Wasmtime GitHub notifications bot (Oct 24 2022 at 15:48):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Oct 24 2022 at 15:48):

abrown created PR review comment:

Same comment here and below.

Wasmtime GitHub notifications bot (Oct 24 2022 at 15:48):

abrown created PR review comment:

We should probably use the same if syntax here for consistency...

Wasmtime GitHub notifications bot (Oct 24 2022 at 15:48):

abrown created PR review comment:

I think it might be preferable to use ANDNPS here: AND-ing the register to itself keeps the same bits in place and the NOT part will do what we want it to do. That way we avoid an extra PCMPEQ* due to the vector_all_ones.

Wasmtime GitHub notifications bot (Oct 24 2022 at 15:48):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Nov 03 2022 at 02:54):

ArtBlnd updated PR #5036 from x86_64-float-bitops1 to main.

Wasmtime GitHub notifications bot (Nov 03 2022 at 02:55):

ArtBlnd submitted PR review.

Wasmtime GitHub notifications bot (Nov 03 2022 at 02:55):

ArtBlnd created PR review comment:

I am not sure we have to make mask for xor or and after xor. also why than our eq tests does not fail because of side-effects?

Wasmtime GitHub notifications bot (Nov 03 2022 at 03:03):

ArtBlnd edited PR review comment.

Wasmtime GitHub notifications bot (Nov 03 2022 at 04:37):

ArtBlnd updated PR #5036 from x86_64-float-bitops1 to main.

Wasmtime GitHub notifications bot (Nov 03 2022 at 04:52):

ArtBlnd created PR review comment:

  src\isa\x64\lower.isle:275:3: type error: Used non-pure constructor 'ty_scalar_float' in pure expression context
  src\isa\x64\lower.isle:337:3: type error: Used non-pure constructor 'ty_scalar_float' in pure expression context
  ```

  ```
(decl ty_scalar_float (Type) Type)
(extern extractor ty_scalar_float ty_scalar_float)

I don't think this is possible now. It should be separate to other patch.

Wasmtime GitHub notifications bot (Nov 03 2022 at 04:52):

ArtBlnd submitted PR review.

Wasmtime GitHub notifications bot (Nov 03 2022 at 04:55):

ArtBlnd updated PR #5036 from x86_64-float-bitops1 to main.

Wasmtime GitHub notifications bot (Nov 04 2022 at 00:03):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Nov 04 2022 at 00:03):

abrown created PR review comment:

Can you re-phrase your question? I'm not sure exactly what you mean...

Wasmtime GitHub notifications bot (Nov 04 2022 at 02:33):

ArtBlnd created PR review comment:

Oh... I misunderstood. just nevermind.

Wasmtime GitHub notifications bot (Nov 04 2022 at 02:33):

ArtBlnd submitted PR review.

Wasmtime GitHub notifications bot (Nov 04 2022 at 02:33):

ArtBlnd edited PR review comment.

Wasmtime GitHub notifications bot (Nov 09 2022 at 01:56):

ArtBlnd submitted PR review.

Wasmtime GitHub notifications bot (Nov 09 2022 at 01:56):

ArtBlnd created PR review comment:

I don't think this works. the andnot will negative the float value itself. here is result.

Caused by:
    Failed test: run: %bnot_f32(0.0) == -NaN:0x3fffff, actual: 0.0

Wasmtime GitHub notifications bot (Nov 09 2022 at 01:57):

ArtBlnd submitted PR review.

Wasmtime GitHub notifications bot (Nov 09 2022 at 01:57):

ArtBlnd created PR review comment:

You can check over here https://www.felixcloutier.com/x86/andnps#andnps--128-bit-legacy-sse-version-

Wasmtime GitHub notifications bot (Nov 09 2022 at 23:33):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Nov 09 2022 at 23:33):

abrown created PR review comment:

Oh, you're right! The NOT happens before the AND. Sorry for the distraction, let me take one more look at everything else...

Wasmtime GitHub notifications bot (Nov 09 2022 at 23:35):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Nov 18 2022 at 04:05):

ArtBlnd updated PR #5036 from x86_64-float-bitops1 to main.

Wasmtime GitHub notifications bot (Nov 18 2022 at 15:45):

abrown merged PR #5036.

Last updated: Nov 22 2024 at 17:03 UTC