Stream: git-wasmtime

Topic: wasmtime / PR #5030 wasmtime-component-macro: struct and ...

Wasmtime GitHub notifications bot (Oct 07 2022 at 00:33):

pchickey edited PR #5030 from pch/component_flags_pub to main:

Previously this created a private type.

Wasmtime GitHub notifications bot (Oct 07 2022 at 00:34):

pchickey edited PR #5030 from pch/component_flags_pub to main:

Previously this created a private type, and private consts.

Wasmtime GitHub notifications bot (Oct 07 2022 at 00:36):

pchickey edited PR #5030 from pch/component_flags_pub to main:

Previously this created a private type, and private consts.

TODO the wit-bindgen version of flags gave a Display impl, and an ::all() constructor,

Wasmtime GitHub notifications bot (Oct 07 2022 at 00:39):

pchickey edited PR #5030 from pch/component_flags_pub to main:

Previously this created a private type, and private consts.

TODO the wit-bindgen version of flags gave a Display impl, and an ::all() constructor, and passes docs through

Wasmtime GitHub notifications bot (Oct 07 2022 at 00:39):

pchickey edited PR #5030 from pch/component_flags_pub to main:

Previously this created a private type, and private consts.

TODO the wit-bindgen version of flags gave a Display impl, and an ::all() constructor, and passes rustdocs through

Wasmtime GitHub notifications bot (Oct 07 2022 at 01:01):

pchickey edited PR #5030 from pch/component_flags_pub to main:

Previously this created a private type, and private consts.

TODO the wit-bindgen version of flags gave a Display impl, an ::all() & an ::empty() constructor, and passes rustdocs through

Wasmtime GitHub notifications bot (Oct 07 2022 at 14:38):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 07 2022 at 20:49):

pchickey updated PR #5030 from pch/component_flags_pub to main.

Wasmtime GitHub notifications bot (Oct 07 2022 at 20:53):

pchickey updated PR #5030 from pch/component_flags_pub to main.

Wasmtime GitHub notifications bot (Oct 07 2022 at 20:56):

pchickey updated PR #5030 from pch/component_flags_pub to main.

Wasmtime GitHub notifications bot (Oct 07 2022 at 23:35):

pchickey edited PR #5030 from pch/component_flags_pub to main:

Previously this created a private type, and private consts.

I also added fn all() -> Self and fn empty() -> Self constructors, because those are the two "most popular" functions from bitflags I stole for the sake of some tests. empty ends up being the same as Default, and all is .empty().not(), so these don't require any actual code generation.

Future work might consider adding the rest of the bitflags methods & impls, and putting the docs through the macro into rustdocs.

Wasmtime GitHub notifications bot (Oct 07 2022 at 23:35):

pchickey has marked PR #5030 as ready for review.

Wasmtime GitHub notifications bot (Oct 07 2022 at 23:36):

pchickey merged PR #5030.

Last updated: Nov 22 2024 at 16:03 UTC